Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert to node package #7

Merged
merged 5 commits into from
Jul 7, 2023
Merged

convert to node package #7

merged 5 commits into from
Jul 7, 2023

Conversation

adbenitez
Copy link
Contributor

@adbenitez adbenitez commented Jul 7, 2023

close #8
close #6

@adbenitez adbenitez self-assigned this Jul 7, 2023
@adbenitez
Copy link
Contributor Author

CI currently failing due to #6

@Simon-Laux
Copy link
Collaborator

Simon-Laux commented Jul 7, 2023

while I agree on using bundlers and typescript, I don't know if we actually need to convert everything, If I had made this with bundlers I would have used npm packages and a framework (such as react), using this hack h() function makes things more complicated, just to not be required to not use bundlers/npm packages.... So I'm not sure about this.

@adbenitez
Copy link
Contributor Author

adbenitez commented Jul 7, 2023

well it is about consistency, I have the webxdc-vite template, and I try to "normalize" all apps to at least have something like that, so maintaining them all is easier and mostly duplicate repetitive work rather than having to jump from npm to yarn, to a python script, to a bash script, to a bash script pulled remotely on CI that then broke because the download link of the script changed (that was the case of this repo) etc.

that is why I was thinking I released tag 10 and there was no attachment because CI broke, it is hard to deal with that not about "I don't like this and that bundler or code formatter"

@adbenitez
Copy link
Contributor Author

ok CI now passes \o/

@adbenitez adbenitez merged commit ddbc232 into master Jul 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

automatic releases don't include attachment error when running typescript as described in readme
2 participants